-
Notifications
You must be signed in to change notification settings - Fork 822
fix: upgrade most packages that use rimraf
and glob
#14153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
rimraf
and glob
rimraf
and glob
rimraf
and glob
Do we need this PR? |
This is an attempt to upgrade packages that use old versions of
The memory leak issue is the most concerning of the 3 warnings, and it comes from versions of |
Additionally if this PR is deemed unnecessary, is it worth the effort to do similar updates in the Gen2 CLI and Data repositories? |
We should do this unless there are blockers. Also looking at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Description of changes
Currently when you install
@amplify/cli
, this message appears:This PR is an attempt to upgrade as many packages as possible that use the deprecated version of these dependencies as well as upgrade the versions of
rimraf
andglob
that are used in our repository (inflight
is a dependency of versions ofglob
before v9, upgrading to v9 or higher resolves theinflight
problem).Many packages were out of date and using deprecated versions of
rimraf
andglob
that had memory leaks. This PR fixes the vast majority of the outdated packages.Some notes about
glob
andrimraf
:glob
andrimraf
not longer have default exports, since we were usingrimraf.sync
andglob.sync
, I switched us to their named export equivalents-f/-r/-rf
has never done anything, it seems people would add them becauserm
takes these argumentsMoved some of the packages that cannot be updated to devDependencies.
Most remaining outdated packages that have not been moved to devDependencies come from data repositories, these will be addressed in a separate PR.
Issue #, if available #13889
Description of how you validated changes
Ensured that the project still builds and the tests still work.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.