Skip to content

Conversation

@osama-rizk
Copy link
Contributor

Description of changes

This PR fixes Android build compilation errors in the rtn-push-notification package that were preventing successful builds on React Native 0.81.4 and newer versions.

Key fixes:

  • Fixed onActivityResult method signature to match the required interface parameters (activity, requestCode, resultCode, data instead of generic p0, p1, p2, p3)
  • Replaced deprecated currentActivity property usage with proper reactApplicationContext.getCurrentActivity() calls
  • Added null safety checks when accessing the current activity to prevent potential crashes

Issue #, if available

Fixes #14594

Description of how you validated changes

  • All existing unit tests pass (12 test suites, 28 tests)

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@osama-rizk osama-rizk requested a review from a team as a code owner December 11, 2025 13:40
@osama-rizk osama-rizk added the run-tests run the pr-label workflow label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests run the pr-label workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rtn-push-notifications not building on Android

3 participants