-
Notifications
You must be signed in to change notification settings - Fork 13
feat(authenticator): Add support for Email MFA #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
vincetran
commented
Oct 25, 2024
tylerjroach
reviewed
Oct 28, 2024
...r/src/test/java/com/amplifyframework/ui/authenticator/ui/SignInContinueWithEmailSetupTest.kt
Show resolved
Hide resolved
tylerjroach
requested changes
Oct 29, 2024
authenticator/src/main/java/com/amplifyframework/ui/authenticator/ui/SignInConfirmCustom.kt
Outdated
Show resolved
Hide resolved
...r/src/test/java/com/amplifyframework/ui/authenticator/ui/SignInContinueWithEmailSetupTest.kt
Show resolved
Hide resolved
tylerjroach
previously approved these changes
Oct 30, 2024
vincetran
commented
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good, @tylerjroach. I can't give an explicit approval because it's my PR.
mattcreaser
previously approved these changes
Oct 30, 2024
d366f9e
mattcreaser
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
L10N Updates
Marks a PR as containing Localization updates, which should be called out in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
The PR aims to add support for Email MFA that has been released by Cognito.
https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-settings-advanced-security-email-mfa.html
The PR for the Amplify-Android change can be found here: aws-amplify/amplify-android#2935
This PR will be in draft mode until the above change has been released so that this PR can ingest the new version.
This PR adds the following new string resources:
How did you test these changes?
Manual testing, new and updated tests pass
Documentation update required?
General Checklist
fix(liveness): message
,fix(authenticator): message
,fix(all): message
)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.