Skip to content

feat(authenticator): Add support for Email MFA #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Conversation

vincetran
Copy link
Member

@vincetran vincetran commented Oct 7, 2024

Issue #, if available: N/A

Description of changes:
The PR aims to add support for Email MFA that has been released by Cognito.
https://docs.aws.amazon.com/cognito/latest/developerguide/cognito-user-pool-settings-advanced-security-email-mfa.html

The PR for the Amplify-Android change can be found here: aws-amplify/amplify-android#2935

This PR will be in draft mode until the above change has been released so that this PR can ingest the new version.

This PR adds the following new string resources:

<string name="amplify_ui_authenticator_button_continue">Continue</string>
<string name="amplify_ui_authenticator_mfa_setup_description">Select your preferred way to verify your identity when using two-factor authentication (2FA). This will be your default method for added account security.</string>
<string name="amplify_ui_authenticator_email_setup_description">Enter the email address you want to use for two-factor authentication (2FA). This email will receive verification codes when you sign in.</string>
<string name="amplify_ui_authenticator_mfa_selection_description">For added security, choose how you want to verify your identity for this sign-in. </string>
<string name="amplify_ui_authenticator_mfa_email">Email Message</string>
<string name="amplify_ui_authenticator_title_signin_continue_setup_mfa_select">Choose your preferred two-factor authentication method to set up</string>
<string name="amplify_ui_authenticator_title_signin_continue_email_setup">Add Email for Two-Factor Authentication</string>

How did you test these changes?
Manual testing, new and updated tests pass

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners October 7, 2024 22:26
@vincetran vincetran marked this pull request as draft October 7, 2024 22:26
@vincetran vincetran marked this pull request as ready for review October 25, 2024 16:43
tylerjroach
tylerjroach previously approved these changes Oct 30, 2024
Copy link
Member Author

@vincetran vincetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good, @tylerjroach. I can't give an explicit approval because it's my PR.

@mattcreaser mattcreaser added the L10N Updates Marks a PR as containing Localization updates, which should be called out in the changelog label Oct 30, 2024
mattcreaser
mattcreaser previously approved these changes Oct 30, 2024
@tylerjroach tylerjroach dismissed stale reviews from mattcreaser and themself via d366f9e October 31, 2024 16:03
@tylerjroach tylerjroach requested a review from a team as a code owner October 31, 2024 16:17
@tylerjroach tylerjroach merged commit 409b53b into main Oct 31, 2024
1 check passed
@tylerjroach tylerjroach deleted the tjroach/email-mfa branch October 31, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L10N Updates Marks a PR as containing Localization updates, which should be called out in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants