Skip to content

fix(authenticator): Add support for auto-sign-in #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

mattcreaser
Copy link
Member

Issue #, if available:

Description of changes:
This change fixes an issue where Authenticator would show an error after signup (requiring an app restart) if USER_AUTH has been enabled for the user pool, even if there is no intention to use that flow for sign in.

This is because having USER_AUTH enabled allows cognito to return the next sign up step of COMPLETE_AUTO_SIGN_IN which Authenticator could not handle. This PR adds support for this result.

How did you test these changes?

  • Unit tests
  • Test app

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners February 24, 2025 14:16
@mattcreaser mattcreaser merged commit 0786720 into main Feb 24, 2025
2 checks passed
@mattcreaser mattcreaser deleted the mattcreaser/auto-sign-in branch February 24, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants