Skip to content

fix(liveness): Prevent crashing if there's an exception thrown by the SurfaceTexture #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

vincetran
Copy link
Member

Issue #, if available: N/A

Description of changes:
We've reports that some old devices were crashing due to this line throwing a Runtime/IllegalStateException. Instead of crashing, we will now silently handle the exception and let the rest of the flow fail back to the app flow. We can now expect the following behaviors:

If the exception happens at the first frame, it'll fail fast because there is existing logic that says "if the camera preview hasn't initialized for the first 5 seconds, throw a camera failed to open exception." Alternatively, if the exception happens after the camera has initialized, the liveness check will eventually time out with an exception thrown with the cause being "Stream idle timeoutExceeded." Both of which are reasonable messaging to the developer.

How did you test these changes?
Had to manually test this since my test devices couldn't reproduce the core issue but were able to manually force the above edge cases to see how the SDK handles it.

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vincetran vincetran requested review from a team as code owners April 29, 2025 19:47
@vincetran vincetran merged commit 79113f9 into main Apr 29, 2025
2 checks passed
@vincetran vincetran deleted the vincetran/opengl-crazh branch April 29, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants