fix(react-storage): upload status not annouced to AT users#6509
Open
fix(react-storage): upload status not annouced to AT users#6509
Conversation
🦋 Changeset detectedLatest commit: a5ef05d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
aadimch
commented
Apr 11, 2025
Comment on lines
+93
to
+98
| return ( | ||
| <> | ||
| <VisuallyHidden role="status">{announcementText()}</VisuallyHidden> | ||
| {renderStatusMessage()} | ||
| </> | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
The VisuallyHidden component is required to be mounted early, so that the user can hear the announcement. It is generally preffered to have the aria-live component, be present in the DOM, as soon as possible.
calebpollman
reviewed
May 1, 2025
| ); | ||
|
|
||
| // Generate the screen reader announcement text | ||
| const announcementText = () => { |
Member
There was a problem hiding this comment.
Will need to provide a callback function through the FileStatusMessage that maps from the top level displayText prop to allow for consumer's to override for i18n
…ough displayText to allow customer override
…hub.com/aws-amplify/amplify-ui into aadimch/fix-upload-status-not-announced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding a new VisuallyHidden Text, that will announce the file upload status changes to screen reader.
Issue #, if available
Description of how you validated changes
Manual testing with VoiceOver
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.