-
Notifications
You must be signed in to change notification settings - Fork 340
feat(authenticator): add passwordless authentication support #6783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 645efc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
afa5561 to
25cf198
Compare
…rifiedUserAttributes
…t coverage threshold
384cd20 to
3ad7250
Compare
| Scenario: Sign in with email shows passwordless UI | ||
| When I type my "email" with status "CONFIRMED" | ||
| Then I see "Sign in with Email" | ||
| Then I see "Other sign-in options" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it feasible to assert the users actually completed their login?
| When I type my "email" with status "CONFIRMED" | ||
| Then I see "Other sign-in options" | ||
|
|
||
| @react |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we assert we are seeing the forget password view upon user clicking the button?
| allowedMfaTypes: ['EMAIL', 'TOTP'], | ||
| selectAuthMethod: jest.fn(), | ||
| availableAuthMethods: undefined, | ||
| toShowAuthMethods: jest.fn(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to assert these functions/fields gets called or initialized
| @@ -0,0 +1,33 @@ | |||
| Feature: Sign In with Passwordless Authentication | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test case for when use enable the passwordless form the props but not in defineAuth?
Description of changes
This PR adds passwordless authentication support to the Authenticator component, enabling users to sign in using SMS OTP, email OTP, and passkeys (WebAuthn).
Key features:
SignInSelectAuthFactorcomponent for selecting authentication methodsPasskeyPromptcomponent for passkey registration after sign-in/sign-upChanges include:
PasskeyPrompt,SignInSelectAuthFactorIconPasskey,IconCheckCircleFillIssue #, if available
Description of how you validated changes
PasskeyPromptandSignInSelectAuthFactorcomponentsenvironments/auth/auth-with-passwordless) for manual testingChecklist
yarn testpasses and tests are updated/addedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.