Skip to content

Conversation

@osama-rizk
Copy link
Contributor

Description of changes

Fix authenticator signup confirmation flow to redirect users to sign-in screen instead of signup screen when coming from refresh scenario. This improve the UX where users who refresh the page between signup and email confirmation are incorrectly redirected back to the signup flow after confirming their email.

Changes:
• Add shouldManualSignIn guard to detect refresh scenario (DONE + CONFIRM_SIGN_UP context)
• Add manualSignIn state that redirects to sign-in screen with setSignInStep action
• Update confirmSignUp onDone handlers to include shouldManualSignIn condition
• Add console logs for debugging and verification

Behavior:
Normal flow: User signs up → confirms email → auto signed in ✅
Refresh flow: User signs up → refresh → sign in → confirms email → redirected to sign-in screen ✅

Issue #, if available

Fixes inconsistent user experience in signup confirmation flow after page refresh.

Description of how you validated changes

• Tested both normal signup flow (auto sign-in works)
• Tested refresh scenario (now redirects to sign-in instead of signup)

Checklist

• [x] Have read the Pull Request Guidelines
• [x] PR description included
• [ ] yarn test passes and tests are updated/added
• [x] PR title and commit messages follow conventional commit syntax
• [x] If this change should result in a version bump, changeset added (This can be done
after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@osama-rizk osama-rizk requested a review from a team as a code owner January 6, 2026 16:58
@changeset-bot
Copy link

changeset-bot bot commented Jan 6, 2026

⚠️ No Changeset found

Latest commit: 7a6aac2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@osama-rizk osama-rizk marked this pull request as draft January 6, 2026 16:58
@osama-rizk osama-rizk added the run-tests Adding this label will trigger tests to run label Jan 6, 2026
@github-actions github-actions bot removed the run-tests Adding this label will trigger tests to run label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants