Skip to content

Conversation

@osama-rizk
Copy link
Contributor

@osama-rizk osama-rizk commented Jan 20, 2026

Description of changes

Fix StorageBrowser controlled mode validation to properly handle empty string prefix. The validation logic was incorrectly using a falsy check (!location[key]) which treated empty strings as missing parameters.

Issue Reference

• Links to GitHub issue #6807

Validation Process

  1. Unit Tests - All pass + new test cases added
  2. Build Verification - Successful builds and TypeScript compilation
  3. Link the UI package to a sample app and verify the issue is fixed.

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@osama-rizk osama-rizk requested a review from a team as a code owner January 20, 2026 14:49
@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2026

⚠️ No Changeset found

Latest commit: 856f83d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants