-
Notifications
You must be signed in to change notification settings - Fork 340
chore(deps): update aws-amplify version. #6816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
package.json
Outdated
| "@types/react-test-renderer": "^18.3.0", | ||
| "@vitejs/plugin-vue": "^2.3.4", | ||
| "aws-amplify": "6.15.9", | ||
| "aws-amplify": "^6.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to use caret versioning here? The previous version was specifically pinned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the pinned version.
| "@angular/core": ">= 19.0.0", | ||
| "@angular/common": ">= 19.0.0", | ||
| "aws-amplify": "^6.14.3", | ||
| "aws-amplify": "^6.16.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we need to change this (i.e. hot-fix, etc.)? I am asking because the caret versioning we had before should install the latest minor version by default while being backwards compatible with versions all the way to 6.14.3.
This question also applies to the other package.json files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmedhamouda78 this is due to version resolution in the yarn.lock
if it resolves to (let's say) 6.14.5 it fulfills ^6.14.3 and would never bump the version (unless major release as you say).
deleting the yarn.lock (or at least the aws-amplify segments) would do the trick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deleting the yarn.lock
I deleted yarn.lock and re-install.
|
short question: have you tried simply removing all |
587f28e to
0dd0a7a
Compare
Description of changes
Updated
aws-amplifypeer dependency from^6.14.3to^6.16.0across all packages in the monorepo to ensure version consistency and prevent dependency conflicts for end users. Also updated theaws-amplifyversion in the rootpackage.json.Files updated:
package.json(both peer dependency and regular dependency)package.jsonfiles (React, Vue, Angular, React Native, and related packages)yarn.lockto reflect dependency changesThis change aligns all packages to use the same aws-amplify version, following monorepo best practices.
Issue #, if available
N/A - Maintenance update to align aws-amplify versions
Description of how you validated changes
package.jsonfiles now referenceaws-amplify: "^6.16.0"package.jsonaws-amplify version updated to^6.16.0yarn.lockwas properly updatedChecklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.