Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPC Flowlogs feature implementation #138

Merged
merged 1 commit into from
Jun 14, 2023
Merged

VPC Flowlogs feature implementation #138

merged 1 commit into from
Jun 14, 2023

Conversation

nnbu
Copy link
Contributor

@nnbu nnbu commented Jun 6, 2023

This change implements flowlogs in ec2 operator.
It adds e2e tests for the flowlogs feature.

Issue #: aws-controllers-k8s/community#1560

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from LikithaVemulapalli and vijtrip2 June 6, 2023 22:59
@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 6, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 6, 2023

Hi @nnbu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nnbu nnbu mentioned this pull request Jun 6, 2023
Open
@nnbu
Copy link
Contributor Author

nnbu commented Jun 6, 2023

Please refer my another PR (and the comment) which is created so that code-generator generates correct code for flow-logs.

aws-controllers-k8s/code-generator#452 (comment)

jaypipes
jaypipes suggested changes Jun 7, 2023
View reviewed changes
@nnbu nnbu force-pushed the flow_log branch 2 times, most recently from 74e87c2 to e1c439c Compare June 7, 2023 21:53
@nnbu nnbu requested a review from jaypipes June 7, 2023 22:03
jaypipes
jaypipes suggested changes Jun 8, 2023
View reviewed changes
@nnbu nnbu force-pushed the flow_log branch 2 times, most recently from d797f20 to 08af212 Compare June 10, 2023 04:41
@nnbu nnbu requested a review from jaypipes June 13, 2023 06:52
jaypipes
jaypipes approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on this @nnbu, thank you for your patience! :)

@nnbu
Copy link
Contributor Author

nnbu commented Jun 13, 2023

/assign @jljaco

@jljaco
Copy link
Contributor

jljaco commented Jun 13, 2023

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2023
VPC Flowlogs feature implementation
f144775 
This change implements flowlogs in ec2 operator.
It adds e2e tests for the flowlogs feature.
LikithaVemulapalli
LikithaVemulapalli approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nnbu :)

@ack-prow ack-prow bot added the approved label Jun 14, 2023
@LikithaVemulapalli
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 14, 2023
@ack-prow
Copy link

ack-prow bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaypipes, LikithaVemulapalli, nnbu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot merged commit 124784e into aws-controllers-k8s:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaypipes jaypipes jaypipes approved these changes

@LikithaVemulapalli LikithaVemulapalli LikithaVemulapalli approved these changes

@vijtrip2 vijtrip2 Awaiting requested review from vijtrip2

Assignees

@LikithaVemulapalli LikithaVemulapalli

@jljaco jljaco

Labels
approved lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nnbu @jljaco @LikithaVemulapalli @jaypipes