ALS-1969 Location disable search fix #106
Open
+63
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_search_fix ALS-1969 Location disable search fix
Comment on lines
+1079
to
1081
| if (!isDefaultLocationNeeded) return mLatLng | ||
|
|
||
| return if (mLatLng == null) { |
There was a problem hiding this comment.
My understanding of the prior code is
- It checks if isLocationComponentActivated = null, which I'm guessing is the check to understand if the live location is enabled
- If null, returns the default location.
i'm not sure I follow why we need an additional flag - Doesn't the current code also do the same?
There was a problem hiding this comment.
On the flip side if we know that a default location is needed from the caller, we should instead have a different method getDefaultLocation that returns mLatLng and update occurrences of getLiveLocation(true)/getLiveLocation() to getDefaultLocation instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
fix: when the location is disabled, take the location from the centre of the map to calculate the search distance.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
