Skip to content

chore: update Kafka deserialization to use alias for ConsumerRecords #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 2, 2025

Please provide the issue number

Issue number: #912

Summary

Changes

Fix --no-restore tests
Transient dependencies not being used properly when using package cache

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2025
@boring-cyborg boring-cyborg bot added the tests label Jul 2, 2025
@github-actions github-actions bot added the internal Maintenance changes label Jul 2, 2025
Copy link

sonarqubecloud bot commented Jul 2, 2025

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (02ce3f8) to head (5dfd998).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #922   +/-   ##
========================================
  Coverage    77.26%   77.26%           
========================================
  Files          272      272           
  Lines        10812    10812           
  Branches      1264     1264           
========================================
  Hits          8354     8354           
  Misses        2046     2046           
  Partials       412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hjgraca hjgraca merged commit b445d3f into develop Jul 2, 2025
9 checks passed
@hjgraca hjgraca deleted the fix/tests-kafka-dependency branch July 2, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants