Vikash/radagent #107
Open
Vikash/radagent #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just chatted with Vikash and he is going to submit a new PR with some updates to the S3 bucket naming as well |
|
@brianloyal, @hasanp87 Updates the changes recommended for s3 bucket names |
hasanp87
requested changes
May 23, 2025
There was a problem hiding this comment.
Thanks for the updates
- There are merge conflicts that need to be resolved
- The README doc calls out Nova Micro at the start, the agent in the notebook seems to use Sonnet 3.0 - can you clarify the role of the LLMs with the agent, and also standardize the choice of LLMs similar to other agents in this repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixed the changes in readme file as recommended. In addition, also updated automatic upload of guidance document to s3 and sample reports in a dynamodb table.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.