Optimize ENI slot reservation for non-supported instance type

[phuhung273]

What type of PR is this?
improvement

Which issue does this PR fix?:
Close #3094

What does this PR do / Why do we need it?:
Do not reserve ENI slot for non-supported instance type

Testing done on this change:
make unit-test

Will this PR introduce any new dependencies?:
No

Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Can the team show me how to test this case ?

Does this change require updates to the CNI daemonset config files to work?:
No

Does this PR introduce any user-facing change?:

Optimize ENI slot reservation for non-supported instance type

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[Copilot]

Pull Request Overview

This PR prevents ENI slot reservation on instance types that don’t support ENI trunking by introducing a check in the IPAMD logic and wiring it through AWS utils and tests.

• Add lists of non-supported ENI trunking instance types/families and implement IsENITrunkingSupported
• Update hasRoomForEni to account for trunking support
• Extend mocks and unit tests in both ipamd and awsutils packages to cover the new trunking flag

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/ipamd/ipamd.go	Added IsENITrunkingSupported check in hasRoomForEni
pkg/ipamd/ipamd_test.go	Expanded test cases (testIncreaseIPPool) to include trunking
pkg/awsutils/no_eni_trunking_instance_types.go	Defined noENITrunkingInstanceTypes and noENITrunkingInstanceFamilies
pkg/awsutils/awsutils.go	Implemented IsENITrunkingSupported using new slices
pkg/awsutils/mocks/awsutils_mocks.go	Added mock recorder and implementation for IsENITrunkingSupported
pkg/awsutils/awsutils_test.go	Added unit tests for IsENITrunkingSupported

Comments suppressed due to low confidence (3)

pkg/ipamd/ipamd_test.go:514

• The parameter name 'unschedulabeNode' is misspelled and may confuse readers. Consider renaming it to 'unschedulableNode'.

func testIncreaseIPPool(t *testing.T, useENIConfig bool, unschedulabeNode bool, subnetDiscovery bool, eniTrunking bool) {

pkg/ipamd/ipamd.go:2236

• Consider adding unit tests for hasRoomForEni to verify its behavior when ENI trunking is supported versus not supported, ensuring the trunkEni offset is applied correctly.

if c.awsClient.IsENITrunkingSupported() && c.enablePodENI && c.dataStore.GetTrunkENI() == "" {

pkg/ipamd/ipamd_test.go:668

• [nitpick] This test sets MY_NODE_NAME but doesn’t unset it; environment state may leak between tests. Consider using defer os.Unsetenv("MY_NODE_NAME") or explicitly calling os.Unsetenv in teardown.

func TestIncreasePrefixPoolDefault(t *testing.T) {

[phuhung273]

Hi @jayanthvn @yash97, do you think this PR reasonable to go ahead ?