refactor(apprunner): consolidate name validations for App Runner Resources and improve error messages #32062
Conversation
github-actions
bot
added
the
distinguished-contributor
aws-cdk-automation
added
the
pr/needs-community-review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32062 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 105 105
Lines 7164 7164
Branches 1311 1311
=======================================
Hits 5530 5530
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| ); | ||
| } | ||
|
|
||
| if (!/^[A-Za-z0-9][A-Za-z0-9\-_]*$/.test(props.vpcConnectorName)) { |
There was a problem hiding this comment.
From Cfn document, it seems that hyphen is not allowed for the VPC Connector name.
^[A-Za-z0-9][A-Za-z0-9-\\_]{3,39}$
There was a problem hiding this comment.
@badmintoncryer
Thanks.
I think regex pattern in Cfn document is wrong.
I successfully created a VPC Connector with a name containing hyphens.
According to the management console, VPC connector names can only contain alphanumeric characters, hyphens, and underscores.
While the regex pattern in the CFn documentation indicates that backslashes are allowed, in practice they are not permitted.
I would like to provide feedback regarding this documentation to AWS team.
There was a problem hiding this comment.
Thank you for your information! I understand.
aws-cdk-automation
removed
the
pr/needs-community-review
aws-cdk-automation
added
the
pr/needs-maintainer-review
Issue # (if applicable)
N/A
Reason for this change
Consolidate name validations for App Runner Resources and improve error messages.
Description of changes
autoScalingConfigurationNameinAutoScalingConfigurationobservabilityConfigurationNameinObservabilityConfigurationNamevpcIngressConnectionNameinVpcIngressConnectionNameserviceNameinServiceName. (Ref: CFn document)vpcConnectorNameinVpcConnectorName. (Ref: CFn document)Description of how you validated changes
Modify and add unit tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license