feat(ses): maximum delivery time for emails #32102
Conversation
github-actions
bot
added
the
distinguished-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| * | ||
| * This value must be greater than or equal to 5 minutes and less than or equal to 14 hours. | ||
| * | ||
| * @default - 14 hours |
There was a problem hiding this comment.
This default value is described at Advanced delivery options/Maximum delivery duration section.
Setting a custom maximum delivery limit (shorter than the SES default of 14 hours),
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
added
pr/needs-maintainer-review
| * | ||
| * This value must be greater than or equal to 5 minutes and less than or equal to 14 hours. | ||
| * | ||
| * @default - 14 hours |
There was a problem hiding this comment.
nit: I'd be specific here, @default undefined - SES defaults to 14 hours
There was a problem hiding this comment.
I've updated!
| if (props.maxDeliveryDuration.toMilliseconds() < Duration.seconds(1).toMilliseconds()) { | ||
| throw new Error(`The maximum delivery duration must be greater than or equal to 5 minutes (300 seconds), got: ${props.maxDeliveryDuration.toMilliseconds()} milliseconds.`); |
There was a problem hiding this comment.
Is this check needed if we already have the 5 min check?
There was a problem hiding this comment.
You're right. I removed the redundancy check.
| const configurationSet = new CfnConfigurationSet(this, 'Resource', { | ||
| deliveryOptions: undefinedIfNoKeys({ | ||
| sendingPoolName: props.dedicatedIpPool?.dedicatedIpPoolName, | ||
| tlsPolicy: props.tlsPolicy, | ||
| maxDeliverySeconds: props.maxDeliveryDuration?.toSeconds(), |
There was a problem hiding this comment.
What happen if it's an unresolved token and calling toSeconds()?
There was a problem hiding this comment.
In this case, an error is thrown.
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/core/lib/duration.ts#L332
If we make it accept a number instead of a Duration, it could also support tokens. However, personally, I prefer using Duration. What do you think we should do?
aws-cdk-automation
removed
the
pr/needs-maintainer-review
mergify
bot
dismissed
GavinZZ’s stale review
Pull request has been modified.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32102 +/- ##
=======================================
Coverage 77.19% 77.19%
=======================================
Files 105 105
Lines 7164 7164
Branches 1311 1311
=======================================
Hits 5530 5530
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
None
Reason for this change
Amazon Simple Email Service (SES) offers a new delivery option that allows us to set a custom maximum delivery time for our emails at Oct 15, 2024
Cfn documentation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ses-configurationset-deliveryoptions.html#cfn-ses-configurationset-deliveryoptions-maxdeliveryseconds
Description of changes
Add
maxDeliveryDurationtoConfigurationSetProps.Description of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license