-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli-plugin-contract): introduce a public contract between CLI and plugins #32111
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32111 +/- ##
==========================================
+ Coverage 77.30% 77.31% +0.01%
==========================================
Files 114 113 -1
Lines 7627 7623 -4
Branches 1360 1359 -1
==========================================
- Hits 5896 5894 -2
+ Misses 1549 1547 -2
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* | ||
* Guaranteed to be called only if canProvideCredentails() returned true at some point. | ||
*/ | ||
getProvider(accountId: string, mode: Mode): Promise<AwsCredentials>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change this to a strongly typed string, we can make this package types only.
getProvider(accountId: string, mode: Mode): Promise<AwsCredentials>; | |
getProvider(accountId: string, mode: 'ForReading' | 'ForWriting'): Promise<AwsCredentials>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be a breaking change for plugins, which are expecting a number (ForReading
= 0, ForWriting
= 1).
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
The contract between the CLI and credential provider plugins is not publicly defined.
Extract the types involved in the CLI-plugin communication into a new package,
@aws-cdk/cli-plugin-contract
, and update all references in the CLI code.Closes #32099.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license