Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamodb): add warm-throughput to L2 #32128

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LeeroyHannigan
Copy link
Contributor

Issue # (if applicable)

Closes #32127

Reason for this change

New feature for DynamoDB

Description of changes

Implemented warm throughput for Table and TableV2

Description of how you validated changes

Unit + Integ tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2024 09:53
@github-actions github-actions bot added feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Nov 14, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 14, 2024 10:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Comment on lines +1 to +12
{
"typeName" : "AWS::DynamoDB::GlobalTable",
"description" : "Version: None. Resource Type definition for AWS::DynamoDB::GlobalTable",
"additionalProperties" : false,
"nonPublicProperties": [
"/properties/WarmThroughput",
"/properties/GlobalSecondaryIndexes/items/properties/WarmThroughput"
],
"nonPublicDefinitions": [
"/definitions/WarmThroughput",
"/definitions/GlobalSecondaryIndex/properties/WarmThroughput"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't want temporary schemas to be merged in. This is more testing purposes on your local. Curious when will the schema be available and when's the expected launch date?

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment on temporary schema.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@4af1564). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32128   +/-   ##
=======================================
  Coverage        ?   77.19%           
=======================================
  Files           ?      105           
  Lines           ?     7164           
  Branches        ?     1311           
=======================================
  Hits            ?     5530           
  Misses          ?     1454           
  Partials        ?      180           
Flag Coverage Δ
suite.unit 77.19% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 331e3c2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dynamodb): l2 construct for warm-throughput feature
3 participants