-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dynamodb): add warm-throughput to L2 #32128
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
{ | ||
"typeName" : "AWS::DynamoDB::GlobalTable", | ||
"description" : "Version: None. Resource Type definition for AWS::DynamoDB::GlobalTable", | ||
"additionalProperties" : false, | ||
"nonPublicProperties": [ | ||
"/properties/WarmThroughput", | ||
"/properties/GlobalSecondaryIndexes/items/properties/WarmThroughput" | ||
], | ||
"nonPublicDefinitions": [ | ||
"/definitions/WarmThroughput", | ||
"/definitions/GlobalSecondaryIndex/properties/WarmThroughput" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally don't want temporary schemas to be merged in. This is more testing purposes on your local. Curious when will the schema be available and when's the expected launch date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a minor comment on temporary schema.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32128 +/- ##
=======================================
Coverage ? 77.19%
=======================================
Files ? 105
Lines ? 7164
Branches ? 1311
=======================================
Hits ? 5530
Misses ? 1454
Partials ? 180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32127
Reason for this change
New feature for DynamoDB
Description of changes
Implemented warm throughput for Table and TableV2
Description of how you validated changes
Unit + Integ tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license