-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: new resource reference interfaces #35032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
if (!c.name.startsWith('Cfn')) { | ||
return false; | ||
} | ||
|
||
return true; | ||
return c.name.startsWith('Cfn'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
For every L1, generate a new interface called
ICfn[ResourceName]
and make them implement this interface. For example:Each individual part of a composite attribute is exposed individually:
In a synthesized template, each of these attributes will be rendered as a
"Fn::Select": [n, "Fn::Split": ["|", {"Ref": "ResourceName"}]]
, wheren
corresponds to the position of that particular identifier in the overall string.Basically adapted from #28189.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license