fix(applicationautoscaling): validate schedule expression format in scaleOnSchedule#37237
Open
fix(applicationautoscaling): validate schedule expression format in scaleOnSchedule#37237
Conversation
…caleOnSchedule Add runtime validation in `ScalableTarget.scaleOnSchedule()` to check that the schedule expression matches valid Application Auto Scaling formats: `cron(...)`, `rate(...)`, or `at(...)`. This catches the common mistake of importing `Schedule` from `aws-cdk-lib/aws-autoscaling` instead of `aws-cdk-lib/aws-applicationautoscaling`, which produces bare cron expressions (e.g. `30 3 * * *`) that fail at deploy time. The validation provides a clear error message guiding users to the correct import. Closes aws#30502
github-actions
bot
added
beginning-contributor
aws-cdk-automation
requested changes
Mar 12, 2026
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Author
|
Exemption Request This change adds a synth-time validation in An integration test is not applicable here because:
|
aws-cdk-automation
added
the
pr-linter/exemption-requested
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
added
the
pr/needs-community-review
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
aws-cdk-automation
temporarily deployed
to
automation
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add runtime validation in
ScalableTarget.scaleOnSchedule()to check that the schedule expression matches valid Application Auto Scaling formats:cron(...),rate(...), orat(...).This catches the common mistake of importing
Schedulefromaws-cdk-lib/aws-autoscalinginstead ofaws-cdk-lib/aws-applicationautoscaling, which produces bare cron expressions (e.g.30 3 * * *) that fail at deploy time with a cryptic CloudFormation error.Closes #30502
What should reviewers focus on
scaleOnSchedule()— it skips unresolved Tokens and only checks resolved string expressionsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license