Skip to content

chore(build): update dotnet version check to support .NET 10+#37256

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
ashrafee-dev:fix/dotnet-10-version-check
Mar 17, 2026
Merged

chore(build): update dotnet version check to support .NET 10+#37256
mergify[bot] merged 3 commits intoaws:mainfrom
ashrafee-dev:fix/dotnet-10-version-check

Conversation

@ashrafee-dev
Copy link
Contributor

@ashrafee-dev ashrafee-dev commented Mar 16, 2026

Issue # (if applicable)

Closes #37261

Reason for this change

.NET 10 is now out: Announcing .NET 10
The prerequisite check does not currently recognize .NET 10 SDK versions.

A similar update was previously made for .NET 9, and this change extends the version check so contributors using .NET 10 do not fail setup unnecessarily.

Description of changes

Updated the dotnet prerequisite version check regex to recognize .NET 10 SDK versions.

This keeps the existing behavior for previously allowed versions and fixes the case where two-digit major versions were not accepted by the check.

Describe any new or updated permissions being added

No new permissions are required.

Description of how you validated changes

  • Reproduced the failure locally with .NET SDK 10.0.105
  • Updated the version check to allow 10.x SDKs
  • Verified the prerequisite check passes with the updated regex

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 16, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 16, 2026 04:05
@ashrafee-dev ashrafee-dev force-pushed the fix/dotnet-10-version-check branch from 1d999d5 to 3e73955 Compare March 16, 2026 20:21
@ashrafee-dev ashrafee-dev changed the title chore(build): add dotnet 10 to prerequisite check fix(build): update dotnet version check to support .NET 10+# Mar 16, 2026
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@ashrafee-dev ashrafee-dev changed the title fix(build): update dotnet version check to support .NET 10+# chore(build): update dotnet version check to support .NET 10+# Mar 16, 2026
@ashrafee-dev ashrafee-dev changed the title chore(build): update dotnet version check to support .NET 10+# fix(build): update dotnet version check to support .NET 10+# Mar 16, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 16, 2026 20:26

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@ashrafee-dev ashrafee-dev force-pushed the fix/dotnet-10-version-check branch from 3e73955 to 18bedde Compare March 16, 2026 20:29
@ashrafee-dev ashrafee-dev changed the title fix(build): update dotnet version check to support .NET 10+# chore(build): update dotnet version check to support .NET 10+# Mar 16, 2026
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 16, 2026 20:31

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@ashrafee-dev ashrafee-dev force-pushed the fix/dotnet-10-version-check branch from 18bedde to 15baeca Compare March 16, 2026 20:33
@ashrafee-dev
Copy link
Contributor Author

Updated the PR title and commit message from fix(build) to chore(build) because the fix type triggered the automation rule requiring test changes, which does not apply to this build prerequisite update.

@alvazjor alvazjor changed the title chore(build): update dotnet version check to support .NET 10+# chore(build): update dotnet version check to support .NET 10+ Mar 17, 2026
@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

Merge Queue Status

  • Entered queue2026-03-17 11:14 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-03-17 13:23 UTC · at f3f0e92dc5e3e064cc507589d73b01eb7c65ea1f

This pull request spent 2 hours 9 minutes 11 seconds in the queue, including 2 hours 8 minutes 55 seconds running CI.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b336700 into aws:main Mar 17, 2026
18 of 19 checks passed
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: check-build-prerequisites.sh rejects dotnet 10.0.105

3 participants