Fix installing setup dependencies for bundled installer on newer versions of pip #9420
+147
−45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: CLI-6153
Don't think we have a GitHub issue, but this has been reported on a few Q&A sites:
Description of changes:
--find-links file://{local path}
syntax to install the packages from the bundle, rather than PyPI. At some point (not apparent from pip's changelog, still trying to pinpoint), this started throwingValueError: non-local file URIs are not supported on this platform: 'file://.
.file://
syntax since--find-links
can accept local paths (see example 10 onpip install
docs).ModuleNotFoundError: No module named 'setuptools'
since it's no longer included by default.setuptools
to ourBUILDTIME_DEPS
that we install first.setuptools
from sdist, which looks like it needs to bootstrap itself. I switched to wheels to alleviate this, though just for theBUILDTIME_DEPS
to start. Refresh bundled installer to work with modern pip/venv #4756 alluded to this as future work.urllib3
for the bundled installer to a version before2.0.0
(where they started requiringhatchling
). We previously pinnedcolorama
for a similar reason.Testing
Added new GitHub action to test making the bundle and installing it across our usual Python version + OS matrix.
I'll manually test a dry-run through the internal build system.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.