[v2] Add support for chunking performance tests #9485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashovlin
reviewed
Jun 10, 2025
Comment on lines
+260
to
+262
| - `mode` (string) **(optional)**: The write mode to use for writing the | ||
| file contents. | ||
| - Default: `w` |
There was a problem hiding this comment.
Is anything actually using this? It looks hardcoded below in _create_file_with_size and begin_iteration.
There was a problem hiding this comment.
It is used in line 136 of simple_stubbed_tests.py
There was a problem hiding this comment.
Oops, I just saw the w and thought it was hardcoded, but that's just the fallback.
ashovlin
approved these changes
Jun 17, 2025
aemous
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
The main purpose of this PR is adding 'chunking' support to performance tests to enable sharding of the tests across parallel workers in a distributed workflow. The secondary purpose of this PR is to refactor the architecture of the performance testing code to make it easier to integrate more complex performance tests. The architectural decisions were led by implementing more complex RPCv2 CBOR performance test cases and observing points of friction.
Description of changes:
BaseBenchmarkSuiteclass which defines the abstract functions that must be implemented to define new performance tests. The default performance test cases were abstracted out into aJSONStubbedBenchmarkSuiteimplementation.JSONStubbedBenchmarkSuitedimensionsformat to require the usage ofnameandvaluekeys to reflect the CloudWatch Metrics model.modekey onfile_literalsdefinition.BenchmarkResultsSerializerclass. This makes it easier to override this class for one-off performance testing when a different output format is expected.Summarizerto return metric results in a newMetricdata model, which includes additional data like description and unit.Description of tests:
./scripts/performance/run-benchmarks --num-iterations 20and observed expected results.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.