-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StdLib): Go v0.0.1 release #1195
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some overall things:
|
Co-authored-by: Rishav karanjit <[email protected]>
MCM is answered here: https://amzn-aws.slack.com/archives/G01813NHQBD/p1736791637977939?thread_ts=1736559063.433249&cid=G01813NHQBD
|
Shouldn't it be prefixed with path from the runtime?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline. The GitHub tag is prefixed with subdirectories.
Non blocking but it could be great if we could have a CI test to do go build to check if the copied code works correctly.
LGTM
Are you talking about git tag or Go tag? The git tag would be something like Here's an example to explain this: https://github.com/ShubhamChaturvedi7/aws-cryptographic-material-providers-library-go/releases/tag/smithy-dafny-standard-library%2Fv0.0.1-alpha |
Issue #, if available:
Description of changes:
Other files are polymorphed files.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.