feat(dafny): Branch Key Store without modifying Encryption Context #1416

texastony · 2025-04-09T17:45:53Z

Issue #, if available:

Description of changes:

This is ONLY a breaking change to consumers of the mutation/mutation branch
that introduced the Branch Key Store Admin.

Squash/merge commit message, if applicable:

feat(dafny)!: Branch Key Store without modifying Encryption Context

BREAKING CHANGE: Branch Key Store Admin has the following breaking changes for eventual MRK support:
- The MRK option in `KmsSymmetricKeyArn` has been removed entirely; it never worked properly and never could work as the region was not supplied.

TODO Key Words

TODO-HV-2-M# :: related to a milestone
TODO-HV-2-BLOCKER :: blocker for internal launch
TODO-HV-2-FOLLOW :: post internal launch
TODO-HV-2-GA :: blocker for going to main

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…re module (#1356)

BREAKING CHANGE: Branch Key Store Admin has the following breaking changes for MRK support: - `KmsSymmetricKeyArn` has dropped the MRK option entirely

… HV-2 (#1366) Co-authored-by: texastony <[email protected]>

Co-authored-by: Tony Knapp <[email protected]> By-passing after Verification checks were met.

Co-authored-by: Tony Knapp <[email protected]>

Co-authored-by: Tony Knapp <[email protected]> Overriding CI check as only one .NET workflow failed due to a typical failure in .NET with SigV4 creds.

Co-authored-by: Tony Knapp <[email protected]>

…1401) Skipping CI to ensure that all future PRs from us do not impact mainline.

…1400) Co-authored-by: Tony Knapp <[email protected]> Co-authored-by: Rishav karanjit <[email protected]> Modified to account for MRK

Duvet references in the code base are from spec reference that has not been pushed to mutations/mutations. For now, we will disable duvet, and re-enable it once mutations has been updated.

Hitting DDB Race condition bug in .NET.

…tation (#1440)

…1465)

…rom hv-2 (#1475)

)

Co-authored-by: Tony Knapp <[email protected]>

@josecorella

Bypassing strict approval requirements. PR was written by @josecorella, approved by @texastony, and then has 2 commits by @texastony; GitHub will not let @josecorella approve these last 2 commits, so we bypassing the rule.

Co-authored-by: Tony Knapp <[email protected]>

…ey (#1487)

Co-authored-by: Darwin Chowdary <[email protected]>

…ion (#1507)

I am By passing a CI failure in Java . It is with Mutations, one of the three Java tests failed: ``` TestMutateHierarchyVersion.TestHV1toHV2HappyCaseDecryptEncrypt: FAILED dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy(313,6): Actual customer send EC and expected customer send EC did not match. ``` We should look into this...

…xpected (#1544)

texastony force-pushed the hv-2/hv-2 branch from 2e99106 to 999ae15 Compare April 14, 2025 23:24

imabhichow and others added 4 commits May 21, 2025 07:15

chore: fix CI for HV-2 (#1353)

957e2f0

chore: move ProvideCryptoClient to HierarchicalVersionUtils in KeySto…

91b3255

…re module (#1356)

ci(Go, Rust): disable for current HV-2 work (#1360)

8534db8

feat(BKS & BKSA)!: Smithy Model for HV-2 (#1350)

a07733d

BREAKING CHANGE: Branch Key Store Admin has the following breaking changes for MRK support: - `KmsSymmetricKeyArn` has dropped the MRK option entirely

texastony mentioned this pull request May 21, 2025

feat(dafny): Branch Key Store without modifying Encryption Context #1535

Closed

texastony and others added 24 commits May 21, 2025 08:32

feat(BKS & BKSA)!: Smithy Code Generation for HV-2

616cbe8

BREAKING CHANGE: Branch Key Store Admin has the following breaking changes for MRK support: - `KmsSymmetricKeyArn` has dropped the MRK option entirely

chore(BKS): pack & unpack plainTextTuple (#1362)

bd93db0

chore(BKS): Add Helper functions to select KMS Encryption Context for…

c789353

… HV-2 (#1366) Co-authored-by: texastony <[email protected]>

chore: refactor hv1 functions and methods (#1367)

e873a4d

chore(bks): Add createMdDigest in hvutils (#1361)

00f7558

chore(BKS): add decrypt hook For Hv2 (#1368)

5ae479f

chore(dafny): Add todo for test (#1377)

88220a5

chore(dafny): BranchKeyContext for HV-2 (#1381)

5179f7d

chore(dafny): KS Refactor KeyStoreException (#1383)

01d19ad

Co-authored-by: Tony Knapp <[email protected]> By-passing after Verification checks were met.

chore(dafny): BKS Encrypt Key for HV-1 & HV-2 (#1372)

aa779df

Co-authored-by: Tony Knapp <[email protected]>

chore(dafny): wire get keys with the decrypt hook (#1376)

504904e

chore(dafny): BKS Refactor GetKeys (#1389)

94bdb1a

chore(dafny): add test for get keys (#1388)

a69f1ce

Co-authored-by: Tony Knapp <[email protected]> Overriding CI check as only one .NET workflow failed due to a typical failure in .NET with SigV4 creds.

chore(dafny): add VerifyGetKeysFromStorage to test (#1392)

674a5b9

chore(dafny): Add helper function to VerifyGetKeys (#1396)

6910200

feat(dafny): KSA Create Key Operation for HV-2 (#1374)

06bdc85

Co-authored-by: Tony Knapp <[email protected]>

test(dafny): no touching the static branch-key-id in the dev branch (#…

df44845

…1401) Skipping CI to ensure that all future PRs from us do not impact mainline.

chore(dafny): refactor HV1 MRK test to use helper methods (#1399)

c5560eb

chore(dafny): KSA Add test coverage for creating a hv-2 branch key. (#…

694a328

…1400) Co-authored-by: Tony Knapp <[email protected]> Co-authored-by: Rishav karanjit <[email protected]> Modified to account for MRK

chore: disable duvet (#1414)

681ddae

Duvet references in the code base are from spec reference that has not been pushed to mutations/mutations. For now, we will disable duvet, and re-enable it once mutations has been updated.

chore(java): create key example for HV-2 branch key (#1425)

12355ad

refactor(dafny): rename BKS Error Messages class for legibility (#1429)

04f357b

chore(dafny): Add helper method to decrypt branch key item (#1439)

e4f6355

Hitting DDB Race condition bug in .NET.

chore(dafny): add checks and tests to fail on EC collision on init mu…

0eee175

…tation (#1440)

imabhichow and others added 24 commits May 21, 2025 08:32

chore(dafny): move static branch keys to static key store table (#1459)

c531db2

chore: refactor helper methods for copy & delete branch keys (#1462)

de34f17

chore(dafny): Test hv1 to hv2 mutation (#1461)

021e728

refactor(dafny): move TestMutateToHV2FromHV1 to mutation directory (#…

526475a

…1465)

chore(dafny): Add TODO to support terminal hv-1 but not downgrading f…

cadc57c

…rom hv-2 (#1475)

feat(dafny): support decrypt/encrypt strategy for mutation to hv2 (#1466

5007e81

)

feat(dafny): mutate HV-2 to HV-2 without new version (#1474)

a23508b

Co-authored-by: Tony Knapp <[email protected]>

chore(java): add examples for mutation to hv-2 (#1477)

5dfd823

test(java): BKSA in-flight mutations access denied (#1480)

f277448

feat(dafny): support hv-2 versionKey in KeyStoreAdmin (#1455)

3b37771

Bypassing strict approval requirements. PR was written by @josecorella, approved by @texastony, and then has 2 commits by @texastony; GitHub will not let @josecorella approve these last 2 commits, so we bypassing the rule.

chore(dafny): add version on mutate functionality (#1485)

5be99e3

chore(dafny): fix verification in kms keyring ondecrypt (#1489)

6742ecb

chore(dafny): BKSA Mutations Tests for HV-1 to HV-1 (#1482)

f15be94

Co-authored-by: Tony Knapp <[email protected]>

chore(dafny): Complete Strategy Support for BKSA VersionKey & CreateK…

da4ed9f

…ey (#1487)

chore(dafny): add hv-2 create key proofs (#1499)

f241a5f

chore(dafny): support kms simple for v1 to v1 mutations (#1491)

771c163

chore(dafny): add version key hv-2 proofs (#1504)

2faf00f

chore(dafny): BKS CreateKey remove redundant EC checks for HV-2 (#1508)

6f31f99

Co-authored-by: Darwin Chowdary <[email protected]>

chore(dafny): BKSA refine KMS Error mapping to MutationTo/From except…

affdf5f

…ion (#1507)

chore(dafny): BKSA Tests for Restarting Mutations (#1501)

295e050

chore(dafny): cleanup todos in hv-2 (#1511)

8dcd76a

chore(dafny): add failure for unexpected attribute in EC on HV-2 (#1516)

3c34ccd

chore(dafny): remove duplicate proof in kms keyring (#1526)

279d4af

texastony force-pushed the mutations/mutations branch from 636bd66 to 4d7d498 Compare May 22, 2025 21:19

fix(dafny): BKS & KMS Keyring Verification (#1537)

fec798d

texastony force-pushed the hv-2/hv-2 branch from 268ffd7 to fec798d Compare May 27, 2025 20:05

texastony added 3 commits May 28, 2025 12:50

test(Dafny): BKSA HV1 w/ Emptyish EC fails Mut to HV2 (#1542)

0c0eb75

test(Dafny): Java Integ Test for Escape Chars (#1543)

aebb1c1

test(Dafny): BKS Integ Test ensure EncCtx is prefixed/unprefixed as e…

bd3124d

…xpected (#1544)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(dafny): Branch Key Store without modifying Encryption Context #1416

feat(dafny): Branch Key Store without modifying Encryption Context #1416

Uh oh!

texastony commented Apr 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

feat(dafny): Branch Key Store without modifying Encryption Context #1416

Are you sure you want to change the base?

feat(dafny): Branch Key Store without modifying Encryption Context #1416

Uh oh!

Conversation

texastony commented Apr 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

TODO Key Words

Uh oh!

Uh oh!

texastony commented Apr 9, 2025 •

edited

Loading