Remove jent_read_entropy_safe usage from AWS-LC (main) #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
+ Coverage 78.75% 78.94% +0.18%
==========================================
Files 598 610 +12
Lines 103656 105121 +1465
Branches 14720 14904 +184
==========================================
+ Hits 81635 82983 +1348
- Misses 21368 21487 +119
+ Partials 653 651 -2 ☔ View full report in Codecov by Sentry. |
andrewhop
approved these changes
Jan 11, 2025
andrewhop
suggested changes
Jan 11, 2025
andrewhop
previously approved these changes
Jan 13, 2025
skmcgrail
previously approved these changes
Jan 13, 2025
smittals2
changed the title
andrewhop
approved these changes
Jan 14, 2025
skmcgrail
approved these changes
Jan 14, 2025
manastasova
pushed a commit
to manastasova/aws-lc
that referenced
this pull request
Jan 30, 2025
### Issues: `P186365975` ### Description of changes: These changes remove any usage of jent_read_entropy_safe function from AWS-LC. This function has an implementation vulnerability described [here](https://github.com/smuellerDD/jitterentropy-library/blob/c62c88645f27716f78e1267a182cff40e96081c2/SECURITY.md#2024-12-30). jent_read_entropy_safe is now unused in our codebase, however, it is still present in the Jitter code. These changes are outside the FIPS boundary and do not impact the FIPS integrity hash. ### Call-outs: Eventually, we should pull in the newest Jitter release with the security fix. ### Testing: How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
P186365975Description of changes:
These changes remove any usage of jent_read_entropy_safe function from AWS-LC. This function has an implementation vulnerability described here.
jent_read_entropy_safe is now unused in our codebase, however, it is still present in the Jitter code. These changes are outside the FIPS boundary and do not impact the FIPS integrity hash.
Call-outs:
Eventually, we should pull in the newest Jitter release with the security fix.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.