Remove jent_read_entropy_safe from Jitter code (main) #2110
+1
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
+ Coverage 78.75% 78.76% +0.01%
==========================================
Files 598 598
Lines 103656 103657 +1
Branches 14720 14722 +2
==========================================
+ Hits 81635 81649 +14
+ Misses 21368 21354 -14
- Partials 653 654 +1 ☔ View full report in Codecov by Sentry. |
andrewhop
approved these changes
Jan 11, 2025
andrewhop
requested changes
Jan 11, 2025
Comment on lines
-45
to
-48
| // Draw some entropy with the "safe" API to check if it works. | ||
| EXPECT_EQ(jent_read_entropy_safe(&jitter_ec.instance, | ||
| (char*) data1, data_len), data_len); | ||
|
|
There was a problem hiding this comment.
I think the spirit of this test was a very simple sanity test that jitter was returning unique output based on line 49. Instead of removing this just use the same jent_read_entropy as above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2
Description of changes:
These changes remove the jent_read_entropy_safe function from our library and our Jitter code. This function has an implementation vulnerability described here.
Call-outs:
Eventually, we should pull in the newest Jitter release with the security fix.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.