Compress crypto_test_data.cc #2123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2123 +/- ##
==========================================
- Coverage 78.96% 78.96% -0.01%
==========================================
Files 610 610
Lines 105288 105288
Branches 14910 14911 +1
==========================================
- Hits 83143 83138 -5
- Misses 21493 21499 +6
+ Partials 652 651 -1 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
huge-crypto_test_data.cc
branch
13 times, most recently
from
f82f6f6 to
581dc67
Compare
justsmth
force-pushed
the
huge-crypto_test_data.cc
branch
from
581dc67 to
7b9bc64
Compare
justsmth
changed the title
torben-hansen
approved these changes
Jan 21, 2025
smittals2
approved these changes
Jan 21, 2025
github-merge-queue bot
pushed a commit
to awslabs/mountpoint-s3
that referenced
this pull request
Jan 23, 2025
Update the CRT to the latest releases. This change also updates the exclude list, primarily due to one of the test files being replaced by a compressed (but still large) file: aws/aws-lc#2123 This change pulls in a bug fix (awslabs/aws-c-auth#259), addressing #1207. ### Does this change impact existing behavior? One bug fix is included in CRT changes. ### Does this change need a changelog entry? Does it require a version change? Change log entry added for the CRT fix. It is a bug fix, so patch version bump to `mountpoint-s3-client` remains appropriate. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
keremnc
pushed a commit
to keremnc/mountpoint-s3
that referenced
this pull request
Jan 24, 2025
Update the CRT to the latest releases. This change also updates the exclude list, primarily due to one of the test files being replaced by a compressed (but still large) file: aws/aws-lc#2123 This change pulls in a bug fix (awslabs/aws-c-auth#259), addressing awslabs#1207. ### Does this change impact existing behavior? One bug fix is included in CRT changes. ### Does this change need a changelog entry? Does it require a version change? Change log entry added for the CRT fix. It is a bug fix, so patch version bump to `mountpoint-s3-client` remains appropriate. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the [Developer Certificate of Origin (DCO)](https://developercertificate.org/). Signed-off-by: Daniel Carl Jones <[email protected]>
manastasova
pushed a commit
to manastasova/aws-lc
that referenced
this pull request
Jan 30, 2025
### Issues: Resolves: P189934541 ### Description of changes: * The size of `generated-src/crypto_test_data.cc` is approaching 100MB. This change generates the file into a compressed form. ### Call-outs: Updating scripts related to this files creation and validation. ### Testing: These changes are thoroughly covered by our CI. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves: P189934541
Description of changes:
generated-src/crypto_test_data.ccis approaching 100MB. This change generates the file into a compressed form.Call-outs:
Updating scripts related to this files creation and validation.
Testing:
These changes are thoroughly covered by our CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.