ACVP test harness for ML-DSA

[jakemas]

Issues:

Resolves #CryptoAlg-2819

Description of changes:

Implements:

• https://pages.nist.gov/ACVP/draft-celi-acvp-ml-dsa.html
• https://github.com/usnistgov/ACVP-Server/tree/master/gen-val/json-files/ML-DSA-keyGen-FIPS204
• https://github.com/usnistgov/ACVP-Server/tree/master/gen-val/json-files/ML-DSA-sigGen-FIPS204
• https://github.com/usnistgov/ACVP-Server/tree/master/gen-val/json-files/ML-DSA-sigVer-FIPS204

Additional Details

Added testing for ML-DSA configured withdeterministic = true externalmu = true, false signatureInterface = internal for parameterSet = ML-DSA-44, ML-DSA-65, ML-DSA-87.

We add the ML-DSA sigGen Test Case JSON Schema:

type mlDsaSigGenTestGroup struct {
	ID                 uint64 `json:"tgId"`
	Type               string `json:"testType"`
	ParameterSet       string `json:"parameterSet"`
	Deterministic      bool   `json:"deterministic"`
	SignatureInterface string `json:"signatureInterface"`
	ExternalMu         bool   `json:"externalMu`
	Tests         []struct {
		ID      uint64               `json:"tcId"`
		Message hexEncodedByteString `json:"message"`
		MU      hexEncodedByteString `json:"mu"`
		SK      hexEncodedByteString `json:"sk"`
		RND     hexEncodedByteString `json:"rnd"`
		Context hexEncodedByteString `json:"context"`
		HashAlg string               `json:"hashAlg"`
	}
}

and ML-DSA sigVer Test Case JSON Schema:

type mlDsaSigVerTestGroup struct {
	ID                 uint64 `json:"tgId"`
	Type               string `json:"testType"`
	ParameterSet       string `json:"parameterSet"`
	Deterministic      bool   `json:"deterministic"`
	SignatureInterface string `json:"signatureInterface"`
	ExternalMu         bool   `json:"externalMu`
	Tests        []struct {
		ID        uint64               `json:"tcId"`
		PK        hexEncodedByteString `json:"pk"`
		Message   hexEncodedByteString `json:"message"`
		MU        hexEncodedByteString `json:"mu"`
		Signature hexEncodedByteString `json:"signature"`
		Context   hexEncodedByteString `json:"context"`
                HashAlg   string               `json:"hashAlg"`
	}
}

Testing:

Running ACVP tests
2025/01/17 14:09:39 40 ACVP tests matched expectations
2025/01/17 14:09:40 1 ACVP tests matched expectations
2025/01/17 14:09:41 1 ACVP tests matched expectations
2025/01/17 14:09:42 1 ACVP tests matched expectations
2025/01/17 14:09:44 1 ACVP tests matched expectations
2025/01/17 14:09:46 1 ACVP tests matched expectations
2025/01/17 14:09:48 1 ACVP tests matched expectations
2025/01/17 14:09:50 1 ACVP tests matched expectations
2025/01/17 14:09:52 1 ACVP tests matched expectations
2025/01/17 14:10:09 1 ACVP tests matched expectations
2025/01/17 14:10:10 1 ACVP tests matched expectations
2025/01/17 14:10:11 1 ACVP tests matched expectations
2025/01/17 14:10:12 1 ACVP tests matched expectations
2025/01/17 14:10:12 1 ACVP tests matched expectations

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

[andrewhop]

Why this min/max? Does this affect what is tested or what is approved?

[jakemas]

FIPS 204 defines the context string as a" byte string of 255 or fewer bytes which can be empty (default)".

[andrewhop]

Should this test min 0, max 255?

[jakemas]

Reading through the document again, I see now that messageLength is the length of the message to be signed. contextLength is the length of the context string.

Looking at Table 7 https://pages.nist.gov/ACVP/draft-celi-acvp-ml-dsa.html#name-ml-dsa-siggen-capability-pr, which is where this capabilities string comes from, you'll see that message length's valid values are:

Min: 8, Max: 65536, Incr: 8

that's why it is defined this way in my capabilities JSON.

We're not supporting context sign, but you can see in the same table that contextLength is Min: 0, Max: 2040, Incr: 8.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (5270eca) to head (6545eb0).
Report is 16 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2127   +/-   ##
=======================================
  Coverage   78.96%   78.97%           
=======================================
  Files         610      610           
  Lines      105288   105287    -1     
  Branches    14911    14911           
=======================================
+ Hits        83140    83146    +6     
+ Misses      21496    21487    -9     
- Partials      652      654    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.