Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more debug logging to channelID test failures #2130

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

andrewhop
Copy link
Contributor

Description of changes:

The GitHub Mac runners occasionally fail the Channel ID tests with an error like:

bad error (wanted ':CHANNEL_ID_SIGNATURE_INVALID:' / ''): local error 'channel ID unexpectedly negotiated', child error 'exit status 1', stdout:

This change tries to log more things to get more info to make progress debugging these failures.

Call-outs:

I wasn't able to test this code path locally because I can't get these failures to reproduce locally.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner January 21, 2025 19:20
@andrewhop andrewhop requested a review from skmcgrail January 21, 2025 19:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (3263ce2) to head (f9a3764).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   78.96%   78.95%   -0.01%     
==========================================
  Files         610      610              
  Lines      105288   105288              
  Branches    14910    14910              
==========================================
- Hits        83143    83134       -9     
- Misses      21493    21502       +9     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewhop andrewhop merged commit 43a9f80 into aws:main Jan 21, 2025
123 of 126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants