Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor symbols to work with Ruby's mainline #2132

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

Ruby's made a couple larger refactors to require versions later than OpenSSL 1.1.1.

These changes require us to make a few tweaks to the patch in #2071 and have exposed a couple minor symbols that we don't support. Adding support for the ones that aren't complicated in this PR.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner January 22, 2025 01:49
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (46e9e53) to head (b09f418).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/evp/digestsign.c 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2132   +/-   ##
=======================================
  Coverage   78.96%   78.96%           
=======================================
  Files         610      610           
  Lines      105287   105293    +6     
  Branches    14911    14920    +9     
=======================================
+ Hits        83135    83149   +14     
+ Misses      21499    21492    -7     
+ Partials      653      652    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 merged commit 29be983 into aws:main Jan 22, 2025
123 of 126 checks passed
@samuel40791765 samuel40791765 deleted the fix-ruby-master branch January 22, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants