Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update patches in Ruby CI #2233

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

We've finalized our changes upstream and we should update our patches to previous branches to align. This also helps minimize churn when applying these patches internally.

Call-outs:

N/A

Testing:

CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (8a9ebcf) to head (2ff5668).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2233      +/-   ##
==========================================
- Coverage   79.04%   79.03%   -0.02%     
==========================================
  Files         612      612              
  Lines      106630   106633       +3     
  Branches    15098    15098              
==========================================
- Hits        84291    84278      -13     
- Misses      21685    21702      +17     
+ Partials      654      653       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samuel40791765 samuel40791765 force-pushed the ruby-patch-update branch 4 times, most recently from b6d7c06 to 6257571 Compare March 7, 2025 01:26
@samuel40791765 samuel40791765 marked this pull request as ready for review March 7, 2025 01:26
@samuel40791765 samuel40791765 requested a review from a team as a code owner March 7, 2025 01:26
@samuel40791765 samuel40791765 force-pushed the ruby-patch-update branch 2 times, most recently from ef4accc to a6f7084 Compare March 7, 2025 21:36
@justsmth
Copy link
Contributor

The ruby_release_fips_{0,1}_integration_x86_64 tests are failing:

make[1]: Leaving directory '/codebuild/output/src74814705/src/github.com/aws/aws-lc/RUBY_BUILD_ROOT/ruby-src/ruby_3_4'
/codebuild/output/src74814705/src/github.com/aws/aws-lc/RUBY_BUILD_ROOT/ruby-src/ruby_3_4/tool/lib/test/unit.rb:1147:in 'Test::Unit::GlobOption#complement_test_name': file not found: test/drb/*ssl*.rb (ArgumentError)

@@ -71,14 +71,14 @@ function ruby_patch() {
--branch ${branch}

# Add directory of backport patches if branch is not master.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants