-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update patches in Ruby CI #2233
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
- Coverage 79.04% 79.03% -0.02%
==========================================
Files 612 612
Lines 106630 106633 +3
Branches 15098 15098
==========================================
- Hits 84291 84278 -13
- Misses 21685 21702 +17
+ Partials 654 653 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b6d7c06
to
6257571
Compare
ef4accc
to
a6f7084
Compare
The
|
08f9df3
to
28c2217
Compare
@@ -71,14 +71,14 @@ function ruby_patch() { | |||
--branch ${branch} | |||
|
|||
# Add directory of backport patches if branch is not master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: update comment?
Description of changes:
We've finalized our changes upstream and we should update our patches to previous branches to align. This also helps minimize churn when applying these patches internally.
Call-outs:
N/A
Testing:
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.