Import Jitter Entropy v3.6.2 using new method and switch code to using it #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## randomness_generation #2276 +/- ##
=========================================================
- Coverage 79.05% 79.04% -0.02%
=========================================================
Files 629 629
Lines 107361 107397 +36
Branches 15169 15170 +1
=========================================================
+ Hits 84873 84890 +17
- Misses 21772 21789 +17
- Partials 716 718 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
reviewed
Mar 18, 2025
| @@ -0,0 +1,5 @@ | |||
| name: jitterentropy-library | |||
There was a problem hiding this comment.
Could we just make jitterentropy a git submodule?
There was a problem hiding this comment.
yes, we could. But we do not use it anywhere else. It would be a strictly bigger behaviour change. Probably something we should do a cross the whole library at the same time.
torben-hansen
force-pushed
the
ragdoll_jitter_entropy_v3.6.2
branch
from
3b363fd to
53a0838
Compare
justsmth
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR does three things: 1) Starts using the new Jitter Entropy import method 2) Imports Jitter Entropy v3.6.2 3) switch to using the new imported code.
Code changes at the AWS-LC level are based on #2220.
Jitter Entropy imported source code is now in under
/third-party/jitterentropy/jitterentropy-library/. Meta data on the import is in/third_party/jitterentropy/META.yml.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.