Add FIPS callback tests for x86 AL2023 and arm AL2/AL2023 #2311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
=======================================
Coverage 78.75% 78.76%
=======================================
Files 620 620
Lines 107936 107936
Branches 15336 15336
=======================================
+ Hits 85008 85016 +8
+ Misses 22271 22266 -5
+ Partials 657 654 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
previously approved these changes
Apr 7, 2025
samuel40791765
previously approved these changes
Apr 8, 2025
andrewhop
dismissed stale reviews from samuel40791765 and WillChilds-Klein
via
27347c5
…around compiler bug in GCC 11.5.0
skmcgrail
approved these changes
Apr 21, 2025
WillChilds-Klein
approved these changes
Apr 21, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Fixes P218664081
Description of changes:
Cover a small testing gap for an AL2023 customers that want to use the callback feature.
Callouts
Why change where a stack variable is defined? This works around a compiler bug with GCC 11.5 that was causing the incorrect result from memcmp to be returned and the integrity check for some algorithms to get the wrong result. P218664081
This is a different GCC version with a subtly different version of the memcmp bug from #73. In this case we can fix our code to work around the issue and we have tests that ensure all the integrity and CAST tests work as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.