Skip to content

Remove unused Gerrit and BoringSSL Bot configuration #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewhop
Copy link
Contributor

Description of changes:

AWS-LC does not use Gerrit or the Google build server and doesn't need any of this configuration.

Call-outs:

I quickly skimmed these files and didn't find anything useful that we would want to use/keep.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner April 7, 2025 21:53
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (4924695) to head (e6d8bf8).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2316      +/-   ##
==========================================
+ Coverage   78.73%   78.75%   +0.01%     
==========================================
  Files         616      620       +4     
  Lines      107589   107936     +347     
  Branches    15285    15333      +48     
==========================================
+ Hits        84712    85001     +289     
- Misses      22223    22278      +55     
- Partials      654      657       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

samuel40791765
samuel40791765 previously approved these changes Apr 7, 2025
skmcgrail
skmcgrail previously approved these changes Apr 16, 2025
@skmcgrail
Copy link
Member

skmcgrail commented Apr 16, 2025

Sanitize job is failing, as it seems to rely on this: https://github.com/aws/aws-lc/blob/main/CMakeLists.txt#L900-L910

@skmcgrail skmcgrail dismissed stale reviews from samuel40791765 and themself via e6d8bf8 April 17, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants