-
Notifications
You must be signed in to change notification settings - Fork 128
Add SecP384r1MLKEM1024 #2327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add SecP384r1MLKEM1024 #2327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 78.77% 78.75% -0.02%
==========================================
Files 620 620
Lines 107874 107892 +18
Branches 15323 15321 -2
==========================================
- Hits 84977 84970 -7
- Misses 22239 22265 +26
+ Partials 658 657 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks good to me! |
}; | ||
|
||
CONSTEXPR_ARRAY uint16_t kPQGroups[] = { | ||
SSL_GROUP_KYBER512_R3, | ||
SSL_GROUP_KYBER768_R3, | ||
SSL_GROUP_KYBER1024_R3, | ||
SSL_GROUP_MLKEM512, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that MLKEM-512 was missing from the list of all PQ groups. AWS-LC doesn't offer MLKEM-512 standalone yet, but when it's supported it should be in this list. Adding it now avoid having it be missing later.
This list is used to ensure that one PQ and and one ECDHE KeyShare is sent in the ClientHello.
Issues:
Adds support for
SecP384r1MLKEM1024
from https://datatracker.ietf.org/doc/draft-ietf-tls-ecdhe-mlkem/Description of changes:
Adds support for
SecP384r1MLKEM1024
hybridCall-outs:
None
Testing:
SecP384r1MLKEM1024
SecP384r1MLKEM1024
against Openssl v3.5.0 with AWS-LC as both client and serverBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.