Make ASN1_get_object a direct call #2332
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
==========================================
- Coverage 78.77% 78.76% -0.01%
==========================================
Files 620 620
Lines 107874 107872 -2
Branches 15323 15322 -1
==========================================
- Hits 84977 84965 -12
- Misses 22239 22252 +13
+ Partials 658 655 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WillChilds-Klein
approved these changes
Apr 15, 2025
| int indefinite_ok) { | ||
| // |ASN1_get_object| parses an ASN.1 header, including tag, class, and length | ||
| // information. The tag number is written to |*out_tag|. The class is written to | ||
| // |*out_class|. If the tag is not indefinite, the content length is written to |
There was a problem hiding this comment.
nit: might want to document that this gets set to 0 if tag is indefinite.
There was a problem hiding this comment.
Yeah, this would align with what's documented for the BSDs:
... If the length octet indicates the indefinite form, *plength is set to 0.
justsmth
approved these changes
Apr 18, 2025
| int indefinite_ok) { | ||
| // |ASN1_get_object| parses an ASN.1 header, including tag, class, and length | ||
| // information. The tag number is written to |*out_tag|. The class is written to | ||
| // |*out_class|. If the tag is not indefinite, the content length is written to |
There was a problem hiding this comment.
Yeah, this would align with what's documented for the BSDs:
... If the length octet indicates the indefinite form, *plength is set to 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
eafd940 made all calls to ASN1 parsers able to parse indefinite length BER. This work to do this was easier thanks to cfe86a3, but this also removes the need for the divergent logic in
asn1_get_object_maybe_indefinite.Call-outs:
N/A
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.