Skip to content

[DRAFT] Add EVP_read_pw_string #2402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

smittals2
Copy link
Contributor

Issues:

Resolves #ISSUE-NUMBER1
Addresses #ISSUE-NUMBER2

Description of changes:

Describe AWS-LC’s current behavior and how your code changes that behavior. If there are no issues this pr is resolving, explain why this change is necessary.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 changed the title Add EVP_read_pw_string [DRAFT] Add EVP_read_pw_string May 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2025

Codecov Report

Attention: Patch coverage is 68.47291% with 64 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (7d9cbf3) to head (fa2e7d8).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
crypto/fipsmodule/evp/evp.c 0.00% 29 Missing ⚠️
crypto/pem/pem_passwd.c 79.56% 19 Missing ⚠️
crypto/pem/pem_lib.c 0.00% 14 Missing ⚠️
crypto/pem/pem_test.cc 97.01% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2402      +/-   ##
==========================================
+ Coverage   78.76%   78.82%   +0.06%     
==========================================
  Files         620      622       +2     
  Lines      107961   108587     +626     
  Branches    15330    15416      +86     
==========================================
+ Hits        85032    85595     +563     
- Misses      22274    22321      +47     
- Partials      655      671      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants