[UPSTREAM] Fix BIO_eof for BIO pairs #2440
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See uptream's 3105d695358d86c0f2a404b2b74a1870b941ce5e. Fleshed out BIO pair tests to cover all these cases. Change-Id: I5fd7f9c08c50b1462459c19a34230212b81cb674 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78829 Reviewed-by: Adam Langley <[email protected]> Commit-Queue: Adam Langley <[email protected]> Auto-Submit: David Benjamin <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2440 +/- ##
==========================================
+ Coverage 78.88% 78.90% +0.02%
==========================================
Files 621 621
Lines 108670 108670
Branches 15419 15419
==========================================
+ Hits 85719 85744 +25
+ Misses 22280 22256 -24
+ Partials 671 670 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See upstream commits:
See uptream's 3105d695358d86c0f2a404b2b74a1870b941ce5e. Fleshed out BIO pair tests to cover all these cases.
Change-Id: I5fd7f9c08c50b1462459c19a34230212b81cb674
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/78829
Reviewed-by: Adam Langley [email protected]
Commit-Queue: Adam Langley [email protected]
Auto-Submit: David Benjamin [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.