Remove sys headers from bio.h #2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
remove-sys-headers
branch
2 times, most recently
from
f526e73 to
47606a1
Compare
samuel40791765
force-pushed
the
remove-sys-headers
branch
from
47606a1 to
523d74d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
==========================================
+ Coverage 78.85% 78.87% +0.02%
==========================================
Files 640 640
Lines 109560 109560
Branches 15520 15518 -2
==========================================
+ Hits 86389 86415 +26
+ Misses 22471 22447 -24
+ Partials 700 698 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
skmcgrail
approved these changes
Jun 25, 2025
torben-hansen
approved these changes
Jun 26, 2025
Merged
skmcgrail
added a commit
that referenced
this pull request
Jun 27, 2025
## What's Changed * Rename SSL test files to match Scrutinice filter by @nhatnghiho in #2491 * Order tool output by options provided - x509 by @justsmth in #2454 * Fix Console Test Suite Execution Locally by @smittals2 in #2493 * Re-remove afunix.h by @justsmth in #2495 * Note a couple of typoed struct names that we'll leave alone. by @justsmth in #2499 * Document that EVP_PKEY_CTX_set_rsa_keygen_pubexp takes ownership by @justsmth in #2503 * Remove sys headers from bio.h by @samuel40791765 in #2508 * rwlock race tests is not a GoogleTest executable by @torben-hansen in #2509 * Add two new APIs to expose TLS 1.3 traffic secrets for kTLS by @skmcgrail in #2506 * Intentionally redefine iovec in headers as CI by @samuel40791765 in #2512 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-3316,CryptoAlg-3292,CryptoAlg-3310,CryptoAlg-3284, andCryptoAlg-3346.Description of changes:
Some internal builds are failing due to the duplicate header file references that
bio.hhas.The
sockaddrreferences requires the<sys/socket.h>header to exist, but it turns out we never actually implementedBIO_dgram_get_mtu_overhead. RemovingBIO_dgram_get_mtu_overheadfor now allows us to get around the "redefinition failure".OpenSSL gets around the
sockaddrby containingBIO_dgram_get_mtu_overheadin a macro pointing toBIO_ctrl. We'll likely have to do the same here when we eventually implementBIO_dgram_get_mtu_overhead.Callouts
I'll introduce CI for the issue in another PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.