Fix uninitialized EVP_MD_CTX and harden bn_dup_into#3033
Merged
Conversation
justsmth
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
justsmth
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
justsmth
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
justsmth
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
justsmth
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
justsmth
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3033 +/- ##
=======================================
Coverage 78.37% 78.37%
=======================================
Files 689 689
Lines 121148 121148
Branches 16973 16974 +1
=======================================
Hits 94948 94948
- Misses 25302 25303 +1
+ Partials 898 897 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkostic
approved these changes
Feb 25, 2026
sgmenda
approved these changes
Mar 6, 2026
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 11, 2026
### Description of changes: In `rsa_key_fips_pairwise_consistency_test_signing`, `md_ctx` was used uninitialized if `EVP_PKEY_new` or `EVP_PKEY_set1_RSA` failed before `EVP_MD_CTX_init` was reached. The cleanup path would then call `EVP_MD_CTX_cleanse` on garbage stack data. Move the init to immediately after declaration so all goto paths are safe. Also add an aliasing guard to `bn_dup_into` to prevent a use-after-free if `*dst` and `src` ever point to the same `BIGNUM`, and remove a dead variable left over from refactoring in `RSA_check_fips`. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license. Co-authored-by: Sanketh Menda <sgmenda@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
In
rsa_key_fips_pairwise_consistency_test_signing,md_ctxwas used uninitialized ifEVP_PKEY_neworEVP_PKEY_set1_RSAfailed beforeEVP_MD_CTX_initwas reached. The cleanup path would then callEVP_MD_CTX_cleanseon garbage stack data. Move the init to immediately after declaration so all goto paths are safe.Also add an aliasing guard to
bn_dup_intoto prevent a use-after-free if*dstandsrcever point to the sameBIGNUM, and remove a dead variable left over from refactoring inRSA_check_fips.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.