-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: Add .env file support for local Lambda invocations #8297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dcabib
wants to merge
12
commits into
aws:develop
Choose a base branch
from
dcabib:feature/dotenv-support
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f3f091a
feat: Add .env file support for local Lambda invocations
dcabib 2fc00b1
chore: Update reproducible requirements for python-dotenv
dcabib 946c15f
Fix: --container-dotenv not working - fixed DebugContext.__bool__
dcabib 274fb56
fix: Address all code review feedback from reedham
dcabib 3d18841
Merge branch 'aws:develop' into feature/dotenv-support
dcabib 9a7074d
Merge branch 'develop' into feature/dotenv-support
roger-zhangg da11247
Merge branch 'develop' into feature/dotenv-support
reedham-aws 3b941d1
refactor: remove library behavior tests per reedham feedback
dcabib 8a56be1
style: format test file with black
dcabib 160afa8
feat: add function-specific environment variable support to .env files
dcabib 02b0975
fix: Replace underscore with asterisk separator for function-specific…
dcabib 3290daf
Merge branch 'develop' into feature/dotenv-support
reedham-aws File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is the following cases for function name:
MyFunctionmyFunctionmy_functionFor 1, it should work fine. For 2, it would not correctly pick up that it's Pascal case because it's not capitalized. For 3, it would take
myas the function name incorrectly. I think the best way to do this might be to use a separator that can't be used in a function name (*for example). This way I think you wouldn't have to rely on the Pascal case and have the problem with the separator being possible in a function name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done