Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move default backoff strategies to the builders to match the docs #5698

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

sugmanue
Copy link
Contributor

@sugmanue sugmanue commented Nov 5, 2024

Motivation and Context

As reported offline the javadocs of the retries strategies do not match the defaults, in particular regarding the backoff strategies, since those are only applied in the static builders in DefaultRetryStrategy class. This change moves setting the default backoff strategies out of DefaultRetryStrategy and into the builders themselves.

Modifications

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link

sonarcloud bot commented Nov 5, 2024

@sugmanue sugmanue marked this pull request as ready for review November 5, 2024 17:59
@sugmanue sugmanue requested a review from a team as a code owner November 5, 2024 17:59
@sugmanue sugmanue added this pull request to the merge queue Nov 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2024
@sugmanue sugmanue added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 2bd0261 Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants