Fix: Warn about SSL Certificate verification being disabled only when it's actually disabled #6005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Initializing a CRT-based
S3AsyncClientwith.httpConfiguration(c -> c.trustAllCertificatesEnabled(ignoreCertificate))(ignoreCertificatebeing a client-configured flag), works well for settingignoreCertificate = Boolean.TRUEduring tests. However, changing such flag toBoolean.FALSEdidn't make the warning message go away, even though SSL Certificate was verified in this last case. The warning message turns out misleading in this case.Modifications
Basically, only
Boolean.TRUEdisables SSL Certificate Validation, so bothnullas well asBoolean.FALSEshould skip the warning message.Testing
Since it's just a ternary
Booleancheck, I've just verified the state ofclientTlsContextOptions.verifyPeerright after theifstatement with a debugger.Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License