Skip to content

test(snapshot-testing): implement response snapshots#7803

Merged
kuhe merged 1 commit intomainfrom
kuhe/test/snapshot-responses
Mar 9, 2026
Merged

test(snapshot-testing): implement response snapshots#7803
kuhe merged 1 commit intomainfrom
kuhe/test/snapshot-responses

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Mar 2, 2026

Issue

#7788
smithy-lang/smithy-typescript#1900

Description

This adds snapshot generation for response-side (deserialization).
It's less accurate compared to request snapshots since we're mocking a server response, but still valuable.

Checklist

  • If the PR is a feature, add integration tests (*.integ.spec.ts) or E2E tests.
    • It's not a feature.
  • My E2E tests are resilient to concurrent i/o.
    • I didn't write any E2E tests.
  • I added access level annotations e.g. @public, @internal tags and enabled doc generation on the package. Remember that access level annotations go below the description, not above.
    • I didn't add any public functions.
  • Streams - how do they work?? My WebStream readers/locks are properly lifecycled. Node.js stream backpressure is handled. Error handling.
    • No streams here.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kuhe kuhe force-pushed the kuhe/test/snapshot-responses branch 9 times, most recently from aaf4a26 to 288ab40 Compare March 6, 2026 18:45
@kuhe kuhe marked this pull request as ready for review March 6, 2026 19:15
@kuhe kuhe requested a review from a team as a code owner March 6, 2026 19:15
@kuhe kuhe force-pushed the kuhe/test/snapshot-responses branch 7 times, most recently from 84a6a5b to b4931b5 Compare March 9, 2026 14:45
@kuhe kuhe force-pushed the kuhe/test/snapshot-responses branch from b4931b5 to 19eef45 Compare March 9, 2026 15:32
@kuhe kuhe merged commit 2b96330 into main Mar 9, 2026
7 checks passed
@kuhe kuhe deleted the kuhe/test/snapshot-responses branch March 9, 2026 16:25
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants