Ensure checksum is not recalculated on retries #3257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have made a change to core without a corresponding change to the CHANGELOG.md. This change will not result in a new version and will not published unless an entry is added to CHANGELOG.md. |
richardwang1124
approved these changes
Jun 9, 2025
| original_checksum = nil | ||
| t = Tempfile.new | ||
| t.write('original') | ||
| t.rewind |
There was a problem hiding this comment.
Is this rewind necessary if you're already rewinding in the proc below?
There was a problem hiding this comment.
Sort of. It's necessary because if the body is re-read, we would want to ensure that it is the new value. However the body is not re-read (by design). It otherwise would make a checksum of an empty string which is still different but not really the ideal test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already done because of how handlers are set up, but add a test to ensure.