changes after 2 PRs #4939
Draft
changes after 2 PRs #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For testing it is very helpful to isolate sandbox changes to `~/.aws` from the host
…ound thread (aws#4946) Co-authored-by: Richard Li <[email protected]>
…es (aws#4928) Co-authored-by: Richard Li <[email protected]>
…rd events for telemetry. (aws#4951) * Adding Acceptance metrics for UTG
* fix(dev): add error messages for upload URL expiry * Update .changes/next-release/bugfix-caf370b9-c943-4ece-a4c0-81bcefa7a4f5.json Co-authored-by: Richard Li <[email protected]> --------- Co-authored-by: Richard Li <[email protected]>
* Add signout metric * Fix broken sign out
…n OS CPU load is high (aws#4952) * upgrade lsp to 0.1.13 * Update .changes/next-release/feature-ac28b77d-4b47-4312-afe7-ece71de355ed.json Co-authored-by: Richard Li <[email protected]> * Update .changes/next-release/feature-ac28b77d-4b47-4312-afe7-ece71de355ed.json Co-authored-by: Richard Li <[email protected]> --------- Co-authored-by: Richard Li <[email protected]>
* Add metadata to authAddConnection metrics * detekt
* raise max indexing size to 4GB * change log * Update bugfix-e76aa3d8-3d9a-4887-8ce6-018ed4c7c443.json --------- Co-authored-by: Richard Li <[email protected]>
andrewyuq
force-pushed
the
main
branch
2 times, most recently
from
5a466c4 to
5016751
Compare
…servability (aws#4953) **Problem:** Feature dev instrumentation 1) records all failures as `FeatureDevException`, losing information about the specific exception type, and 2) lacks annotation of `reasonDesc` and the operation related to the error. (By operation, although we do capture `amazonq_codeGenerationInvoke`, we're missing the subprocess name such as `StartCodeGeneration`.) As a result, we do not have insight into feature dev failures in JetBrains. **Solution:** 1) Update exception modeling pattern for feature dev functionality to derive subclasses of `FeatureDevException`, providing a meaningful class name when inspected as error `reason`. 2) On `FeatureDevException`, accept an `operation` and `desc` to provide further annotation (merged when logged as `reasonDesc`). This change will have conflicts with aws#4938 and aws#4949. I'll rebase on top of those and reconcile any drift in a subsequent revision.
* Fix lint errors * Fix lint errors for plugin-amazonq:chat * Fix lint errors for plugin-toolkit:jetbrains-core
`CodeWhispererStatusBarWidget#getSelectedValue` is called under EDT, but may cause `ProfileWatcher` to be indirectly initialized on the background through `ToolkitConnectionManager#activeConnectionForFeature`. However `ProfileWatcher` requires EDT to initialize correctly since it relies on VFS events to propagate on EDT before it returns
Required for private forks
In CI, the override just drops all the source because all paths contain `/codebuild` ``` > Task :plugin-amazonq:codewhisperer:jetbrains-community:detektMain NO-SOURCE Skipping task ':plugin-amazonq:codewhisperer:jetbrains-community:detektMain' as it has no source files and no previous output files. Resolve mutations for :plugin-core:jetbrains-community:compileTestFixturesJava (Thread[aws#144,Execution worker Thread 4,5,main]) started. :plugin-core:jetbrains-community:compileTestFixturesJava (Thread[aws#144,Execution worker Thread 4,5,main]) started. ```
…ws#5027) * Depends on aws#4982 * Depends on aws/aws-toolkit-common#899 * Rename Unit -> MetricUnit directly in SDK codegen * Use newer provider convention syntax for input/output in generator task * expose `passive`/`unit`/`value` as special fields * add smoke test for `validateRequiredAttributes`
This PR transforms OTel spans to the format expected by the current telemetry service
* improve indexing auto start stop * lsp 0.1.26
* Add session_start telemetry to startup activities * use runOnceUtil * remove hardcoding of class name * remove order first * internal class
* Fix popup not init in EDT for remote 1. BackendComponentBePopupBuilder.createPopup somehow needs to be executed in EDT while recent changes made our initPopup() to happen in BGT. * Update plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererService.kt Co-authored-by: Richard Li <[email protected]> * change log --------- Co-authored-by: Richard Li <[email protected]>
* add authScopes to emitUserState telemetry * add authScopes to emitUserState telemetry * Replace userState function with direct TelemetryService record function to capture authScopes * add value parameter * fix whitespace * Update plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/gettingstarted/GettingStartedAuthUtils.kt Co-authored-by: Richard Li <[email protected]> * Check current explorerConnection for scopes only * Add function to grab scopes from each activeConnection used that is connected/expired. * remove TelemetryOverride definition and use common's telemetry function instead * remove unused imports * Change the way explorer connection scope is checked * remove check for CodeWhispererConnection: merged into qConnection & qScopes * add common logic to one function * Update telemetryOverride.json missed { --------- Co-authored-by: Richard Li <[email protected]>
* change log to info * lazyLog
* Scrub names from messages in logging/telemetry * removing commented code * feedback * detekt
…stion (aws#5067) Co-authored-by: Richard Li <[email protected]>
* initial commit * add source to loading metrics * detekt * fix tests * fix more tests
…hen indexing finished (aws#5062) * adjust LSP API timeout * update time
Per product request. Tested in internal branch
…ws#5076) Only allow invoking inline chat if it's from regular file editor
* patch for aws#5076 * Update plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/OpenChatInputAction.kt Co-authored-by: Richard Li <[email protected]> --------- Co-authored-by: Richard Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.