-
Notifications
You must be signed in to change notification settings - Fork 594
feat(amazonq): add open settings command #7132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpinkney-aws
wants to merge
1
commit into
aws:master
Choose a base branch
from
jpinkney-aws:open-settings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Apr 23, 2025
@@ -188,6 +197,12 @@ export function registerMessageListeners( | |||
} | |||
break | |||
} | |||
case OPEN_SETTINGS: { | |||
const params = message.params as OpenSettingsParams | |||
const setting = params.settingKey as keyof SettingsProps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might as well be as any
, since as
means this doesn't actually achieve any type-checking. and that avoids needing to export
SettingsProps.
justinmk3
reviewed
Apr 23, 2025
Comment on lines
+201
to
+202
const params = message.params as OpenSettingsParams | ||
const setting = params.settingKey as keyof SettingsProps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const params = message.params as OpenSettingsParams | |
const setting = params.settingKey as keyof SettingsProps | |
const params = message.params as any | |
const setting = params.settingKey as any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chat-client will send an event to VSCode indicating what setting should be opened
Solution
implement the event handler
I can't get this to actually trigger so this code is theoretical for now
feature/x
branches will not be squash-merged at release time.