Skip to content

feat(amazonq): add open settings command #7132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jpinkney-aws
Copy link
Contributor

Problem

chat-client will send an event to VSCode indicating what setting should be opened

Solution

implement the event handler

I can't get this to actually trigger so this code is theoretical for now


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner April 22, 2025 18:56
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jpinkney-aws jpinkney-aws changed the title feat: add open settings command feat(amazonq): add open settings command Apr 22, 2025
@jpinkney-aws jpinkney-aws reopened this Apr 22, 2025
@@ -188,6 +197,12 @@ export function registerMessageListeners(
}
break
}
case OPEN_SETTINGS: {
const params = message.params as OpenSettingsParams
const setting = params.settingKey as keyof SettingsProps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well be as any, since as means this doesn't actually achieve any type-checking. and that avoids needing to export SettingsProps.

Comment on lines +201 to +202
const params = message.params as OpenSettingsParams
const setting = params.settingKey as keyof SettingsProps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const params = message.params as OpenSettingsParams
const setting = params.settingKey as keyof SettingsProps
const params = message.params as any
const setting = params.settingKey as any

@jpinkney-aws jpinkney-aws deleted the branch aws:master May 1, 2025 03:02
@justinmk3 justinmk3 reopened this May 1, 2025
@justinmk3 justinmk3 changed the base branch from feature/hybridChat to master May 1, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants