fix(amazonq): mock vscode.commands.executeCommand to fix flaky tests #8439
+75
−62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Two unit tests were flaky, timing out after 30 seconds in CI but passing locally:
Root cause: buildListRecommendationRequest() calls getWorkspaceId() which executes vscode.commands.executeCommand('aws.amazonq.getWorkspaceId'). This
command may not be registered in the test environment, causing an indefinite hang.
Solution
Mock vscode.commands.executeCommand to return { workspaces: [] } in the affected tests, preventing the hang while still testing the actual logic.
Also extracted duplicate mockServerResult to a helper function to satisfy the duplicate code checker.
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━