feat(amazonq): inline e2e simulation #8464
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Will-ShaoHua
changed the title
|
⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done |
|
|
✅ I finished the code review, and didn't find any security or code quality issues. |
Will-ShaoHua
commented
Jan 20, 2026
| // editCompletionRequestType.method, | ||
| // request, | ||
| // token | ||
| // ) |
Contributor
Author
There was a problem hiding this comment.
temporarily disable NEP request as simulation might get throttled if we fire more requests (NEP)
Will-ShaoHua
commented
Jan 20, 2026
Comment on lines
+257
to
+268
| // this.processRemainingRequests(languageClient, request, result, token) | ||
| // .then(async (flag) => { | ||
| // // Force vscode to reload suggestions | ||
| // await commands.executeCommand('editor.action.inlineSuggest.hide') | ||
| // await commands.executeCommand('editor.action.inlineSuggest.trigger') | ||
|
|
||
| const logstr = `Done pagination; shouldUpdate=${flag}; updatedSuggestionCount=${this.sessionManager.getActiveRecommendation().length}` | ||
| this.logger.info(logstr) | ||
| }) | ||
| .catch((error) => { | ||
| languageClient.warn(`Error when getting suggestions: ${error}`) | ||
| }) | ||
| // const logstr = `Done pagination; shouldUpdate=${flag}; updatedSuggestionCount=${this.sessionManager.getActiveRecommendation().length}` | ||
| // this.logger.info(logstr) | ||
| // }) | ||
| // .catch((error) => { | ||
| // languageClient.warn(`Error when getting suggestions: ${error}`) | ||
| // }) |
Contributor
Author
There was a problem hiding this comment.
also temporarily disable pagination as requests might be throttled
Will-ShaoHua
commented
Jan 20, 2026
| } | ||
|
|
||
| private async processRemainingRequests( | ||
| async processRemainingRequests( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.